usb: hub: remove assignment from if condition

Fix one occurrence of the checkpatch.pl error:

ERROR: do not use assignment in if condition

The semantic patch that makes this change is:

// <smpl>
@@
identifier i;
expression E, E2, E3;
statement S1, S2;
binary operator b;
@@

+ i = E;
  if (
- (i = E)
+ i
  b
  ... && E2 && E3 ) S1 else S2
// </smpl>

Signed-off-by: Kris Borer <kborer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index a0b22be1509d640bf85961ea0580819f2b4ee233..78bd0d671d9a14a7d5ef5e36f6fb2c6e36af9e7c 100644 (file)
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -671,8 +671,8 @@ resubmit:
        if (hub->quiescing)
                return;
 
-       if ((status = usb_submit_urb(hub->urb, GFP_ATOMIC)) != 0
-                       && status != -ENODEV && status != -EPERM)
+       status = usb_submit_urb(hub->urb, GFP_ATOMIC);
+       if (status != 0 && status != -ENODEV && status != -EPERM)
                dev_err(hub->intfdev, "resubmit --> %d\n", status);
 }