]> www.infradead.org Git - users/hch/nvmetcli.git/commitdiff
nvmetcli: set up the target only after the network is configured
authorMaurizio Lombardi <mlombard@redhat.com>
Tue, 28 Feb 2023 16:36:15 +0000 (17:36 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 15 Mar 2023 13:42:30 +0000 (14:42 +0100)
network.target only indicates that the network stack is up, but it
doesn't mean that the network devices have been configured.

Replace it with network-online.target, this fixes the following
error when systemd restores the target configuration during boot:

[   19.613251] nvmet_tcp: failed to bind port socket -99
[FAILED] Failed to start Restore NVMe kernel target configuration.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
nvmet.service

index 5c7991ec22e520c8378f64df1dce05125dfbeb70..6f97a91e01f34e477cba60d156f1d7f3ef9a6460 100644 (file)
@@ -1,7 +1,8 @@
 [Unit]
 Description=Restore NVMe kernel target configuration
 Requires=sys-kernel-config.mount
-After=sys-kernel-config.mount network.target local-fs.target
+After=sys-kernel-config.mount network-online.target local-fs.target
+Wants=network-online.target
 
 [Service]
 Type=oneshot