scsi: hisi_sas: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is
redundant because platform_get_irq() already prints an error
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is
redundant because platform_get_irq() already prints an error
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is
redundant because platform_get_irq() already prints an error

Link: https://lore.kernel.org/r/20220215020524.44268-1-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index 763888144aefc6dd92b720f616c43adb0a9e0b95..4582791def328ff6524d93c644e5f4262b535175 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1638,11 +1638,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
                idx = i * HISI_SAS_PHY_INT_NR;
                for (j = 0; j < HISI_SAS_PHY_INT_NR; j++, idx++) {
                        irq = platform_get_irq(pdev, idx);
-                       if (irq < 0) {
-                               dev_err(dev, "irq init: fail map phy interrupt %d\n",
-                                       idx);
+                       if (irq < 0)
                                return irq;
-                       }
 
                        rc = devm_request_irq(dev, irq, phy_interrupts[j], 0,
                                              DRV_NAME " phy", phy);
@@ -1657,11 +1654,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
        idx = hisi_hba->n_phy * HISI_SAS_PHY_INT_NR;
        for (i = 0; i < hisi_hba->queue_count; i++, idx++) {
                irq = platform_get_irq(pdev, idx);
-               if (irq < 0) {
-                       dev_err(dev, "irq init: could not map cq interrupt %d\n",
-                               idx);
+               if (irq < 0)
                        return irq;
-               }
 
                rc = devm_request_irq(dev, irq, cq_interrupt_v1_hw, 0,
                                      DRV_NAME " cq", &hisi_hba->cq[i]);
@@ -1675,11 +1669,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
        idx = (hisi_hba->n_phy * HISI_SAS_PHY_INT_NR) + hisi_hba->queue_count;
        for (i = 0; i < HISI_SAS_FATAL_INT_NR; i++, idx++) {
                irq = platform_get_irq(pdev, idx);
-               if (irq < 0) {
-                       dev_err(dev, "irq init: could not map fatal interrupt %d\n",
-                               idx);
+               if (irq < 0)
                        return irq;
-               }
 
                rc = devm_request_irq(dev, irq, fatal_interrupts[i], 0,
                                      DRV_NAME " fatal", hisi_hba);