]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
bcachefs: fix incorrect show_options results
authorHongbo Li <lihongbo22@huawei.com>
Thu, 26 Sep 2024 02:00:01 +0000 (10:00 +0800)
committerKent Overstreet <kent.overstreet@linux.dev>
Fri, 18 Oct 2024 04:49:48 +0000 (00:49 -0400)
When call show_options in bcachefs, the options buffer is appeneded
to the seq variable. In fact, it requires an additional comma to be
appended first. This will affect the remount process when reading
existing mount options.

Fixes: 9305cf91d05e ("bcachefs: bch2_opts_to_text()")
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/fs.c

index 506b9a2b5bd7b77c2dd9a5b6086a7f7c85791043..0ea443eeb8cde557a944013af5f127a1d0e9d12f 100644 (file)
@@ -2038,7 +2038,7 @@ static int bch2_show_options(struct seq_file *seq, struct dentry *root)
        bch2_opts_to_text(&buf, c->opts, c, c->disk_sb.sb,
                          OPT_MOUNT, OPT_HIDDEN, OPT_SHOW_MOUNT_STYLE);
        printbuf_nul_terminate(&buf);
-       seq_puts(seq, buf.buf);
+       seq_printf(seq, ",%s", buf.buf);
 
        int ret = buf.allocation_failure ? -ENOMEM : 0;
        printbuf_exit(&buf);