]> www.infradead.org Git - linux.git/commitdiff
mtd: spi-nor: use local variable for struct device
authorTudor Ambarus <tudor.ambarus@linaro.org>
Mon, 11 Nov 2024 11:19:45 +0000 (13:19 +0200)
committerPratyush Yadav <pratyush@kernel.org>
Fri, 6 Dec 2024 16:08:25 +0000 (16:08 +0000)
Use a local variable for the struct device pointers to avoid
dereferencing.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Pratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20241111111946.9048-2-tudor.ambarus@linaro.org
drivers/mtd/spi-nor/core.c

index 66949d9f0cc5a05242bead8129087d5bccc0ac0d..0b50293fc373460638d73eff66df2e53a14e6716 100644 (file)
@@ -3576,7 +3576,8 @@ static int spi_nor_create_write_dirmap(struct spi_nor *nor)
 static int spi_nor_probe(struct spi_mem *spimem)
 {
        struct spi_device *spi = spimem->spi;
-       struct flash_platform_data *data = dev_get_platdata(&spi->dev);
+       struct device *dev = &spi->dev;
+       struct flash_platform_data *data = dev_get_platdata(dev);
        struct spi_nor *nor;
        /*
         * Enable all caps by default. The core will mask them after
@@ -3586,13 +3587,13 @@ static int spi_nor_probe(struct spi_mem *spimem)
        char *flash_name;
        int ret;
 
-       nor = devm_kzalloc(&spi->dev, sizeof(*nor), GFP_KERNEL);
+       nor = devm_kzalloc(dev, sizeof(*nor), GFP_KERNEL);
        if (!nor)
                return -ENOMEM;
 
        nor->spimem = spimem;
-       nor->dev = &spi->dev;
-       spi_nor_set_flash_node(nor, spi->dev.of_node);
+       nor->dev = dev;
+       spi_nor_set_flash_node(nor, dev->of_node);
 
        spi_mem_set_drvdata(spimem, nor);
 
@@ -3628,9 +3629,8 @@ static int spi_nor_probe(struct spi_mem *spimem)
         */
        if (nor->params->page_size > PAGE_SIZE) {
                nor->bouncebuf_size = nor->params->page_size;
-               devm_kfree(nor->dev, nor->bouncebuf);
-               nor->bouncebuf = devm_kmalloc(nor->dev,
-                                             nor->bouncebuf_size,
+               devm_kfree(dev, nor->bouncebuf);
+               nor->bouncebuf = devm_kmalloc(dev, nor->bouncebuf_size,
                                              GFP_KERNEL);
                if (!nor->bouncebuf)
                        return -ENOMEM;