]> www.infradead.org Git - users/hch/misc.git/commitdiff
netfs: Fix netfs_unbuffered_read() to return ssize_t rather than int
authorDavid Howells <dhowells@redhat.com>
Fri, 14 Mar 2025 16:41:59 +0000 (16:41 +0000)
committerChristian Brauner <brauner@kernel.org>
Wed, 19 Mar 2025 09:04:23 +0000 (10:04 +0100)
Fix netfs_unbuffered_read() to return an ssize_t rather than an int as
netfs_wait_for_read() returns ssize_t and this gets implicitly truncated.

Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20250314164201.1993231-5-dhowells@redhat.com
Acked-by: "Paulo Alcantara (Red Hat)" <pc@manguebit.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: Viacheslav Dubeyko <slava@dubeyko.com>
cc: Alex Markuze <amarkuze@redhat.com>
cc: Ilya Dryomov <idryomov@gmail.com>
cc: ceph-devel@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/netfs/direct_read.c

index 0bf3c2f5a710c9e0e71c92d3ae284488303b52e2..5e3f0aeb51f31f6cdf24722c719472bdd0866cf3 100644 (file)
@@ -125,9 +125,9 @@ static int netfs_dispatch_unbuffered_reads(struct netfs_io_request *rreq)
  * Perform a read to an application buffer, bypassing the pagecache and the
  * local disk cache.
  */
-static int netfs_unbuffered_read(struct netfs_io_request *rreq, bool sync)
+static ssize_t netfs_unbuffered_read(struct netfs_io_request *rreq, bool sync)
 {
-       int ret;
+       ssize_t ret;
 
        _enter("R=%x %llx-%llx",
               rreq->debug_id, rreq->start, rreq->start + rreq->len - 1);
@@ -155,7 +155,7 @@ static int netfs_unbuffered_read(struct netfs_io_request *rreq, bool sync)
        else
                ret = -EIOCBQUEUED;
 out:
-       _leave(" = %d", ret);
+       _leave(" = %zd", ret);
        return ret;
 }