]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/xe/configfs: Don't touch survivability_mode on fini
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 4 Sep 2025 10:35:21 +0000 (12:35 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 4 Sep 2025 20:31:26 +0000 (22:31 +0200)
This is a user controlled configfs attribute, we should not
modify that outside the configfs attr.store() implementation.

Fixes: bc417e54e24b ("drm/xe: Enable configfs support for survivability mode")
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250904103521.7130-1-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_survivability_mode.c

index 53c5af4b810cb253f7ae44155279541ad353cd6d..7999cc5262a5c33f2efa1fb7f4aac3aee6d420e7 100644 (file)
@@ -44,6 +44,8 @@
  *
  *     # echo 1 > /sys/kernel/config/xe/0000:03:00.0/survivability_mode
  *
+ * It is the responsibility of the user to clear the mode once firmware flash is complete.
+ *
  * Refer :ref:`xe_configfs` for more details on how to use configfs
  *
  * Survivability mode is indicated by the below admin-only readable sysfs which provides additional
@@ -180,7 +182,6 @@ static void xe_survivability_mode_fini(void *arg)
        struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
        struct device *dev = &pdev->dev;
 
-       xe_configfs_clear_survivability_mode(pdev);
        sysfs_remove_file(&dev->kobj, &dev_attr_survivability_mode.attr);
 }