]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
USB: dwc3: Use syscon_regmap_lookup_by_phandle_args
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 12 Feb 2025 20:29:13 +0000 (21:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2025 08:29:32 +0000 (09:29 +0100)
Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
syscon_regmap_lookup_by_phandle() combined with getting the syscon
argument.  Except simpler code this annotates within one line that given
phandle has arguments, so grepping for code would be easier.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20250212202913.23443-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-am62.c

index c158364bc03e07cfee96fde1641d16c05addec43..9db8f3ca493de90e0bd2c2eebd7a09676598362b 100644 (file)
@@ -153,11 +153,11 @@ static int phy_syscon_pll_refclk(struct dwc3_am62 *am62)
 {
        struct device *dev = am62->dev;
        struct device_node *node = dev->of_node;
-       struct of_phandle_args args;
        struct regmap *syscon;
        int ret;
 
-       syscon = syscon_regmap_lookup_by_phandle(node, "ti,syscon-phy-pll-refclk");
+       syscon = syscon_regmap_lookup_by_phandle_args(node, "ti,syscon-phy-pll-refclk",
+                                                     1, &am62->offset);
        if (IS_ERR(syscon)) {
                dev_err(dev, "unable to get ti,syscon-phy-pll-refclk regmap\n");
                return PTR_ERR(syscon);
@@ -165,14 +165,6 @@ static int phy_syscon_pll_refclk(struct dwc3_am62 *am62)
 
        am62->syscon = syscon;
 
-       ret = of_parse_phandle_with_fixed_args(node, "ti,syscon-phy-pll-refclk", 1,
-                                              0, &args);
-       if (ret)
-               return ret;
-
-       of_node_put(args.np);
-       am62->offset = args.args[0];
-
        /* Core voltage. PHY_CORE_VOLTAGE bit Recommended to be 0 always */
        ret = regmap_update_bits(am62->syscon, am62->offset, PHY_CORE_VOLTAGE_MASK, 0);
        if (ret) {