]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: ti: icssg-prueth: Fix emac link speed handling
authorMD Danish Anwar <danishanwar@ti.com>
Tue, 5 Aug 2025 17:38:12 +0000 (23:08 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 Aug 2025 19:06:12 +0000 (12:06 -0700)
When link settings are changed emac->speed is populated by
emac_adjust_link(). The link speed and other settings are then written into
the DRAM. However if both ports are brought down after this and brought up
again or if the operating mode is changed and a firmware reload is needed,
the DRAM is cleared by icssg_config(). As a result the link settings are
lost.

Fix this by calling emac_adjust_link() after icssg_config(). This re
populates the settings in the DRAM after a new firmware load.

Fixes: 9facce84f406 ("net: ti: icssg-prueth: Fix firmware load sequence.")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Message-ID: <20250805173812.2183161-1-danishanwar@ti.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/icssg/icssg_prueth.c

index 2b973d6e2341cfcfb7869ca0c96d4ff13de798ab..6c7d776ae4eed76d191f91e02bed1ba750106573 100644 (file)
@@ -50,6 +50,8 @@
 /* CTRLMMR_ICSSG_RGMII_CTRL register bits */
 #define ICSSG_CTRL_RGMII_ID_MODE                BIT(24)
 
+static void emac_adjust_link(struct net_device *ndev);
+
 static int emac_get_tx_ts(struct prueth_emac *emac,
                          struct emac_tx_ts_response *rsp)
 {
@@ -229,6 +231,10 @@ static int prueth_emac_common_start(struct prueth *prueth)
                ret = icssg_config(prueth, emac, slice);
                if (ret)
                        goto disable_class;
+
+               mutex_lock(&emac->ndev->phydev->lock);
+               emac_adjust_link(emac->ndev);
+               mutex_unlock(&emac->ndev->phydev->lock);
        }
 
        ret = prueth_emac_start(prueth);