]> www.infradead.org Git - users/hch/misc.git/commitdiff
ref_tracker: remove redundant __GFP_NOWARN
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 5 Aug 2025 02:30:31 +0000 (10:30 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 14 Sep 2025 00:32:43 +0000 (17:32 -0700)
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
GFP_NOWAIT implicitly include __GFP_NOWARN.

Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
`GFP_NOWAIT | __GFP_NOWARN`) is now redundant.  Let's clean up these
redundant flags across subsystems.

No functional changes.

Link: https://lkml.kernel.org/r/20250805023031.331718-1-rongqianfeng@vivo.com
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/ref_tracker.c

index cce12287708ea43e9eda9fe42f82a80423cea4e3..258fb0e7abdf1d72300d040c7be513f581592de1 100644 (file)
@@ -75,7 +75,7 @@ ref_tracker_get_stats(struct ref_tracker_dir *dir, unsigned int limit)
        struct ref_tracker *tracker;
 
        stats = kmalloc(struct_size(stats, stacks, limit),
-                       GFP_NOWAIT | __GFP_NOWARN);
+                       GFP_NOWAIT);
        if (!stats)
                return ERR_PTR(-ENOMEM);
        stats->total = 0;
@@ -159,7 +159,7 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir,
                return;
        }
 
-       sbuf = kmalloc(STACK_BUF_SIZE, GFP_NOWAIT | __GFP_NOWARN);
+       sbuf = kmalloc(STACK_BUF_SIZE, GFP_NOWAIT);
 
        for (i = 0, skipped = stats->total; i < stats->count; ++i) {
                stack = stats->stacks[i].stack_handle;
@@ -306,7 +306,7 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
        }
        nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
        stack_handle = stack_depot_save(entries, nr_entries,
-                                       GFP_NOWAIT | __GFP_NOWARN);
+                                       GFP_NOWAIT);
 
        spin_lock_irqsave(&dir->lock, flags);
        if (tracker->dead) {