target/iscsi: Don't log "iSCSI Login negotiation failed." twice

There's no need for iscsi_target_init_negotiation() to print

    iSCSI Login negotiation failed.

on failure, since its only caller (__iscsi_target_login_thread())
prints exactly the same message if it gets an error return back.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 2dba448cac193daf452c16a0eb847a03a2de1d04..a9a73ac88fd030318f28acd6ba45a726e72fdf53 100644 (file)
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -1000,7 +1000,6 @@ struct iscsi_login *iscsi_target_init_negotiation(
         *      Locates Target Portal from NP -> Target IQN
         */
        if (iscsi_target_locate_portal(np, conn, login) < 0) {
-               pr_err("iSCSI Login negotiation failed.\n");
                goto out;
        }