rpmsg: glink: use only lower 16-bits of param2 for CMD_OPEN name length
authorJonathan Marek <jonathan@marek.ca>
Mon, 7 Oct 2024 23:59:35 +0000 (19:59 -0400)
committerBjorn Andersson <andersson@kernel.org>
Sat, 16 Nov 2024 03:32:36 +0000 (19:32 -0800)
The name len field of the CMD_OPEN packet is only 16-bits and the upper
16-bits of "param2" are a different "prio" field, which can be nonzero in
certain situations, and CMD_OPEN packets can be unexpectedly dropped
because of this.

Fix this by masking out the upper 16 bits of param2.

Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241007235935.6216-1-jonathan@marek.ca
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/rpmsg/qcom_glink_native.c

index 0b2f290069080638581a13b3a580054d31e176c2..b534b88db3f8ef40dfee6c5edd33a0f2b13e2151 100644 (file)
@@ -1204,7 +1204,8 @@ void qcom_glink_native_rx(struct qcom_glink *glink)
                        ret = qcom_glink_rx_open_ack(glink, param1);
                        break;
                case GLINK_CMD_OPEN:
-                       ret = qcom_glink_rx_defer(glink, param2);
+                       /* upper 16 bits of param2 are the "prio" field */
+                       ret = qcom_glink_rx_defer(glink, param2 & 0xffff);
                        break;
                case GLINK_CMD_TX_DATA:
                case GLINK_CMD_TX_DATA_CONT: