Input: serio - use sizeof(*pointer) instead of sizeof(type)

It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
Link: https://lore.kernel.org/r/AS8PR02MB7237D3D898CCC9C50C18DE078BFB2@AS8PR02MB7237.eurprd02.prod.outlook.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
index c5b634940cfcff91c63af13df6a0f8d9cad1c4cb..611eb9fe2d04711f1557ac8d7b810283d82bf472 100644 (file)
--- a/drivers/input/serio/altera_ps2.c
+++ b/drivers/input/serio/altera_ps2.c
@@ -100,7 +100,7 @@ static int altera_ps2_probe(struct platform_device *pdev)
                return error;
        }
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
index 8fbfa448be4ac322b2a5c260d3dd379521a9a282..29c421a8e627ae50ca265a0ac887b2246f499a0d 100644 (file)
--- a/drivers/input/serio/ambakmi.c
+++ b/drivers/input/serio/ambakmi.c
@@ -114,8 +114,8 @@ static int amba_kmi_probe(struct amba_device *dev,
        if (ret)
                return ret;
 
-       kmi = kzalloc(sizeof(struct amba_kmi_port), GFP_KERNEL);
-       io = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       kmi = kzalloc(sizeof(*kmi), GFP_KERNEL);
+       io = kzalloc(sizeof(*io), GFP_KERNEL);
        if (!kmi || !io) {
                ret = -ENOMEM;
                goto out;

diff --git a/drivers/input/serio/apbps2.c b/drivers/input/serio/apbps2.c
index dbbb1025152098d2ff1cf2fae0834e485076b2e7..4015e75fcb903d30a70ba20a931c29e81bf00fda 100644 (file)
--- a/drivers/input/serio/apbps2.c
+++ b/drivers/input/serio/apbps2.c
@@ -165,7 +165,7 @@ static int apbps2_of_probe(struct platform_device *ofdev)
        /* Set reload register to core freq in kHz/10 */
        iowrite32be(freq_hz / 10000, &priv->regs->reload);
 
-       priv->io = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       priv->io = kzalloc(sizeof(*priv->io), GFP_KERNEL);
        if (!priv->io)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/arc_ps2.c b/drivers/input/serio/arc_ps2.c
index 9d8726830140110ae92ad2f7df93c1cedd75a438..a9180a00587208d4053337aca81286b373d70830 100644 (file)
--- a/drivers/input/serio/arc_ps2.c
+++ b/drivers/input/serio/arc_ps2.c
@@ -155,7 +155,7 @@ static int arc_ps2_create_port(struct platform_device *pdev,
        struct arc_ps2_port *port = &arc_ps2->port[index];
        struct serio *io;
 
-       io = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       io = kzalloc(sizeof(*io), GFP_KERNEL);
        if (!io)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/ct82c710.c b/drivers/input/serio/ct82c710.c
index d5c9bb3d010382a5311f711d18b5157a4e4055fd..6834440b37f661c864cce639412779a2715007a9 100644 (file)
--- a/drivers/input/serio/ct82c710.c
+++ b/drivers/input/serio/ct82c710.c
@@ -158,7 +158,7 @@ static int __init ct82c710_detect(void)
 
 static int ct82c710_probe(struct platform_device *dev)
 {
-       ct82c710_port = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       ct82c710_port = kzalloc(sizeof(*ct82c710_port), GFP_KERNEL);
        if (!ct82c710_port)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
index 633c7de49d671547e16e257667110e71a1829a67..d94c01eb3fc97322c6303cd2b601b9f510a7772c 100644 (file)
--- a/drivers/input/serio/gscps2.c
+++ b/drivers/input/serio/gscps2.c
@@ -338,8 +338,8 @@ static int __init gscps2_probe(struct parisc_device *dev)
        if (dev->id.sversion == 0x96)
                hpa += GSC_DINO_OFFSET;
 
-       ps2port = kzalloc(sizeof(struct gscps2port), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       ps2port = kzalloc(sizeof(*ps2port), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!ps2port || !serio) {
                ret = -ENOMEM;
                goto fail_nomem;

diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
index 31def6ce515726618cf11961e53facb278098eeb..31d9dacd2fd18967bf6edb837be596116b832467 100644 (file)
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -318,8 +318,8 @@ static int hv_kbd_probe(struct hv_device *hv_dev,
        struct serio *hv_serio;
        int error;
 
-       kbd_dev = kzalloc(sizeof(struct hv_kbd_dev), GFP_KERNEL);
-       hv_serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       kbd_dev = kzalloc(sizeof(*kbd_dev), GFP_KERNEL);
+       hv_serio = kzalloc(sizeof(*hv_serio), GFP_KERNEL);
        if (!kbd_dev || !hv_serio) {
                error = -ENOMEM;
                goto err_free_mem;

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 9fbb8d31575ae1486afcb1e7f70e51ff8d6f5a76..e0fb1db653b7355705d7fb0f35dba9106e5a674c 100644 (file)
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -1329,7 +1329,7 @@ static int i8042_create_kbd_port(void)
        struct serio *serio;
        struct i8042_port *port = &i8042_ports[I8042_KBD_PORT_NO];
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio)
                return -ENOMEM;
 
@@ -1359,7 +1359,7 @@ static int i8042_create_aux_port(int idx)
        int port_no = idx < 0 ? I8042_AUX_PORT_NO : I8042_MUX_PORT_NO + idx;
        struct i8042_port *port = &i8042_ports[port_no];
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/maceps2.c b/drivers/input/serio/maceps2.c
index 5ccfb82759b35613eba024608b088132adddf68b..42ac1eb948662d7927e5eb88edd8ad19e8d87b1d 100644 (file)
--- a/drivers/input/serio/maceps2.c
+++ b/drivers/input/serio/maceps2.c
@@ -117,7 +117,7 @@ static struct serio *maceps2_allocate_port(int idx)
 {
        struct serio *serio;
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (serio) {
                serio->id.type          = SERIO_8042;
                serio->write            = maceps2_write;

diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c
index 240a714f708185335fe507804fdeae6cbb5d8c01..0ad95e880cc20de0d5f958425e40f2ff1c86ca60 100644 (file)
--- a/drivers/input/serio/olpc_apsp.c
+++ b/drivers/input/serio/olpc_apsp.c
@@ -188,7 +188,7 @@ static int olpc_apsp_probe(struct platform_device *pdev)
                return priv->irq;
 
        /* KEYBOARD */
-       kb_serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       kb_serio = kzalloc(sizeof(*kb_serio), GFP_KERNEL);
        if (!kb_serio)
                return -ENOMEM;
        kb_serio->id.type       = SERIO_8042_XL;
@@ -203,7 +203,7 @@ static int olpc_apsp_probe(struct platform_device *pdev)
        serio_register_port(kb_serio);
 
        /* TOUCHPAD */
-       pad_serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       pad_serio = kzalloc(sizeof(*pad_serio), GFP_KERNEL);
        if (!pad_serio) {
                error = -ENOMEM;
                goto err_pad;

diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c
index 0d54895428f5d554cf3983065f68469b959bb4ed..328932297aadb193c4a0f9cba8467bff566eb0e2 100644 (file)
--- a/drivers/input/serio/parkbd.c
+++ b/drivers/input/serio/parkbd.c
@@ -165,7 +165,7 @@ static struct serio *parkbd_allocate_serio(void)
 {
        struct serio *serio;
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (serio) {
                serio->id.type = parkbd_mode;
                serio->write = parkbd_write;

diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
index 05878750f2c2d22eaeb59843fd13b109dafe3b15..6b9abb2e18c9b9a06d6bc0015ab8bf6e16d02b56 100644 (file)
--- a/drivers/input/serio/pcips2.c
+++ b/drivers/input/serio/pcips2.c
@@ -137,8 +137,8 @@ static int pcips2_probe(struct pci_dev *dev, const struct pci_device_id *id)
        if (ret)
                goto disable;
 
-       ps2if = kzalloc(sizeof(struct pcips2_data), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       ps2if = kzalloc(sizeof(*ps2if), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!ps2if || !serio) {
                ret = -ENOMEM;
                goto release;

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index c3ff60859a035b90d20982f9b3fa8047dfb23287..0c8b390b8b4f8d2e80d03128a9646371b3a3c3c5 100644 (file)
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -404,8 +404,8 @@ static int ps2_gpio_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        int error;
 
-       drvdata = devm_kzalloc(dev, sizeof(struct ps2_gpio_data), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!drvdata || !serio) {
                error = -ENOMEM;
                goto err_free_serio;

diff --git a/drivers/input/serio/ps2mult.c b/drivers/input/serio/ps2mult.c
index 902e81826fbfeab1094604172fe177858daec30e..937ecdea491d172ddab18cbd6f164832fe7dff3e 100644 (file)
--- a/drivers/input/serio/ps2mult.c
+++ b/drivers/input/serio/ps2mult.c
@@ -127,7 +127,7 @@ static int ps2mult_create_port(struct ps2mult *psm, int i)
        struct serio *mx_serio = psm->mx_serio;
        struct serio *serio;
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/q40kbd.c b/drivers/input/serio/q40kbd.c
index 3f81f8749cd56cbfd6b3ddcf5978bae491a4e5a1..cd4d5be946a3618bd38f39a860ac93d74c885a08 100644 (file)
--- a/drivers/input/serio/q40kbd.c
+++ b/drivers/input/serio/q40kbd.c
@@ -108,8 +108,8 @@ static int q40kbd_probe(struct platform_device *pdev)
        struct serio *port;
        int error;
 
-       q40kbd = kzalloc(sizeof(struct q40kbd), GFP_KERNEL);
-       port = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       q40kbd = kzalloc(sizeof(*q40kbd), GFP_KERNEL);
+       port = kzalloc(sizeof(*port), GFP_KERNEL);
        if (!q40kbd || !port) {
                error = -ENOMEM;
                goto err_free_mem;

diff --git a/drivers/input/serio/rpckbd.c b/drivers/input/serio/rpckbd.c
index 9bbfefd092c0852c558baef07e71baaecf1f62bd..e236bb7e10144257cae09f11e44d90a29e9524d7 100644 (file)
--- a/drivers/input/serio/rpckbd.c
+++ b/drivers/input/serio/rpckbd.c
@@ -108,7 +108,7 @@ static int rpckbd_probe(struct platform_device *dev)
        if (tx_irq < 0)
                return tx_irq;
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        rpckbd = kzalloc(sizeof(*rpckbd), GFP_KERNEL);
        if (!serio || !rpckbd) {
                kfree(rpckbd);

diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c
index 2724c3aa512cebdbe766633c7639d270ccbb1be3..1311caf7dba4f2b7b39d1b49f694f5c2acb009d2 100644 (file)
--- a/drivers/input/serio/sa1111ps2.c
+++ b/drivers/input/serio/sa1111ps2.c
@@ -256,8 +256,8 @@ static int ps2_probe(struct sa1111_dev *dev)
        struct serio *serio;
        int ret;
 
-       ps2if = kzalloc(sizeof(struct ps2if), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       ps2if = kzalloc(sizeof(*ps2if), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!ps2if || !serio) {
                ret = -ENOMEM;
                goto free;

diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index a8838b52262762848af4267a0e15fd41e34aefe7..04967494eeb6c1235904e143b921ef913a6d69ae 100644 (file)
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -258,7 +258,7 @@ static int serio_queue_event(void *object, struct module *owner,
                }
        }
 
-       event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC);
+       event = kmalloc(sizeof(*event), GFP_ATOMIC);
        if (!event) {
                pr_err("Not enough memory to queue event %d\n", event_type);
                retval = -ENOMEM;

diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index 1e4770094415d300b8d9b2e2866581d262e680fb..0186d1b38f49f86e83f0a866b6cc21f9fb302ba1 100644 (file)
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -92,7 +92,7 @@ static int serio_raw_open(struct inode *inode, struct file *file)
                goto out;
        }
 
-       client = kzalloc(sizeof(struct serio_raw_client), GFP_KERNEL);
+       client = kzalloc(sizeof(*client), GFP_KERNEL);
        if (!client) {
                retval = -ENOMEM;
                goto out;
@@ -293,7 +293,7 @@ static int serio_raw_connect(struct serio *serio, struct serio_driver *drv)
        struct serio_raw *serio_raw;
        int err;
 
-       serio_raw = kzalloc(sizeof(struct serio_raw), GFP_KERNEL);
+       serio_raw = kzalloc(sizeof(*serio_raw), GFP_KERNEL);
        if (!serio_raw) {
                dev_dbg(&serio->dev, "can't allocate memory for a device\n");
                return -ENOMEM;

diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
index 1db3f30011c42dc1fd6ef835613232af29edd35f..5a2b5404ffc21e830293895f7aaba74bea93be3b 100644 (file)
--- a/drivers/input/serio/serport.c
+++ b/drivers/input/serio/serport.c
@@ -82,7 +82,7 @@ static int serport_ldisc_open(struct tty_struct *tty)
        if (!capable(CAP_SYS_ADMIN))
                return -EPERM;
 
-       serport = kzalloc(sizeof(struct serport), GFP_KERNEL);
+       serport = kzalloc(sizeof(*serport), GFP_KERNEL);
        if (!serport)
                return -ENOMEM;
 
@@ -167,7 +167,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file,
        if (test_and_set_bit(SERPORT_BUSY, &serport->flags))
                return -EBUSY;
 
-       serport->serio = serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serport->serio = serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio)
                return -ENOMEM;
 

diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
index aec66d9f517615bf7a8b21432bab07f485f1386c..95cd8aaee65da228dbb7c95873c1d81415e80b5c 100644 (file)
--- a/drivers/input/serio/sun4i-ps2.c
+++ b/drivers/input/serio/sun4i-ps2.c
@@ -213,8 +213,8 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        int error;
 
-       drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!drvdata || !serio) {
                error = -ENOMEM;
                goto err_free_mem;

diff --git a/drivers/input/serio/userio.c b/drivers/input/serio/userio.c
index 9ab5c45c3a9fe1d0008170a205ee55a4cadec438..a88e2eee55c35c784ea101e4e5b909f97af0073c 100644 (file)
--- a/drivers/input/serio/userio.c
+++ b/drivers/input/serio/userio.c
@@ -77,7 +77,7 @@ static int userio_char_open(struct inode *inode, struct file *file)
 {
        struct userio_device *userio;
 
-       userio = kzalloc(sizeof(struct userio_device), GFP_KERNEL);
+       userio = kzalloc(sizeof(*userio), GFP_KERNEL);
        if (!userio)
                return -ENOMEM;
 
@@ -85,7 +85,7 @@ static int userio_char_open(struct inode *inode, struct file *file)
        spin_lock_init(&userio->buf_lock);
        init_waitqueue_head(&userio->waitq);
 
-       userio->serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       userio->serio = kzalloc(sizeof(*userio->serio), GFP_KERNEL);
        if (!userio->serio) {
                kfree(userio);
                return -ENOMEM;

diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index bb758346a33d8d5559c8cd61b3ec91817d9d0fd1..1543267d02acd80c1e582e03730e5da840291b3e 100644 (file)
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -252,8 +252,8 @@ static int xps2_of_probe(struct platform_device *ofdev)
                return -ENODEV;
        }
 
-       drvdata = kzalloc(sizeof(struct xps2data), GFP_KERNEL);
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!drvdata || !serio) {
                error = -ENOMEM;
                goto failed1;