]> www.infradead.org Git - users/hch/misc.git/commitdiff
scsi: qla2xxx: edif: Fix incorrect sign of error code
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 5 Sep 2025 07:54:43 +0000 (15:54 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 Sep 2025 02:04:59 +0000 (22:04 -0400)
Change the error code EAGAIN to -EAGAIN in qla24xx_sadb_update() and
qla_edif_process_els() to align with qla2x00_start_sp() returning
negative error codes or QLA_SUCCESS, preventing logical errors.

Fixes: 0b3f3143d473 ("scsi: qla2xxx: edif: Add retry for ELS passthrough")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Message-ID: <20250905075446.381139-2-rongqianfeng@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_edif.c

index 91bbd3b75bff97b3fa6b08cb1c4f77150218cd98..ccd4485087a1069adf8c76db1066ae309c2d107e 100644 (file)
@@ -1798,7 +1798,7 @@ retry:
        switch (rval) {
        case QLA_SUCCESS:
                break;
-       case EAGAIN:
+       case -EAGAIN:
                msleep(EDIF_MSLEEP_INTERVAL);
                cnt++;
                if (cnt < EDIF_RETRY_COUNT)
@@ -3649,7 +3649,7 @@ retry:
                       p->e.extra_rx_xchg_address, p->e.extra_control_flags,
                       sp->handle, sp->remap.req.len, bsg_job);
                break;
-       case EAGAIN:
+       case -EAGAIN:
                msleep(EDIF_MSLEEP_INTERVAL);
                cnt++;
                if (cnt < EDIF_RETRY_COUNT)