bpf: map_get_next_key to return first key on NULL

[ Upstream commit 8fe45924387be6b5c1be59a7eb330790c61d5d10 ]

When iterating through a map, we need to find a key that does not exist
in the map so map_get_next_key will give us the first key of the map.
This often requires a lot of guessing in production systems.

This patch makes map_get_next_key return the first key when the key
pointer in the parameter is NULL.

Signed-off-by: Teng Qin <qinteng@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>

diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 1c1b8ab340373ee6c69229ab34073833cc5319ad..6c1783bff424708b123371e470809eef5f31423b 100644 (file)
--- a/kernel/bpf/arraymap.c
+++ b/kernel/bpf/arraymap.c
@@ -75,7 +75,7 @@ static void *array_map_lookup_elem(struct bpf_map *map, void *key)
 static int array_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
 {
        struct bpf_array *array = container_of(map, struct bpf_array, map);
-       u32 index = *(u32 *)key;
+       u32 index = key ? *(u32 *)key : U32_MAX;
        u32 *next = (u32 *)next_key;
 
        if (index >= array->map.max_entries) {

diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
index 83c209d9b17ae6b23eb16d0fd0d94b873897ffba..ef7173e82179a47ace2c042eaabf0381c17f64c8 100644 (file)
--- a/kernel/bpf/hashtab.c
+++ b/kernel/bpf/hashtab.c
@@ -149,12 +149,15 @@ static int htab_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
        struct hlist_head *head;
        struct htab_elem *l, *next_l;
        u32 hash, key_size;
-       int i;
+       int i = 0;
 
        WARN_ON_ONCE(!rcu_read_lock_held());
 
        key_size = map->key_size;
 
+       if (!key)
+               goto find_first_elem;
+
        hash = htab_map_hash(key, key_size);
 
        head = select_bucket(htab, hash);
@@ -162,10 +165,8 @@ static int htab_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
        /* lookup the key */
        l = lookup_elem_raw(head, hash, key, key_size);
 
-       if (!l) {
-               i = 0;
+       if (!l)
                goto find_first_elem;
-       }
 
        /* key was found, get next key in the same bucket */
        next_l = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu(&l->hash_node)),

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 3bae6c59191483d48eb5934ad216cc952abaf9b1..0fcb43cb20068ca1c083d62b9b037c571f02f631 100644 (file)
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -311,14 +311,18 @@ static int map_get_next_key(union bpf_attr *attr)
        if (IS_ERR(map))
                return PTR_ERR(map);
 
-       err = -ENOMEM;
-       key = kmalloc(map->key_size, GFP_USER);
-       if (!key)
-               goto err_put;
-
-       err = -EFAULT;
-       if (copy_from_user(key, ukey, map->key_size) != 0)
-               goto free_key;
+       if (ukey) {
+               err = -ENOMEM;
+               key = kmalloc(map->key_size, GFP_USER);
+               if (!key)
+                       goto err_put;
+
+               err = -EFAULT;
+               if (copy_from_user(key, ukey, map->key_size) != 0)
+                       goto free_key;
+       } else {
+               key = NULL;
+       }
 
        err = -ENOMEM;
        next_key = kmalloc(map->key_size, GFP_USER);