]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: phy: fixed_phy: remove member no_carrier from struct fixed_phy
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 6 Sep 2025 22:01:02 +0000 (00:01 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Sep 2025 01:11:50 +0000 (18:11 -0700)
After the recent removal of gpio support member no_carrier isn't
needed any longer.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/fixed_phy.c

index 1ac17ef333e422360623fb65814a9fe7575391c6..35ac29c3e004ca59f527f13c7758a7626a5682fa 100644 (file)
@@ -32,7 +32,6 @@ struct fixed_phy {
        int addr;
        struct phy_device *phydev;
        struct fixed_phy_status status;
-       bool no_carrier;
        int (*link_update)(struct net_device *, struct fixed_phy_status *);
        struct list_head node;
 };
@@ -52,7 +51,7 @@ int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier)
 
        list_for_each_entry(fp, &fmb->phys, node) {
                if (fp->addr == phydev->mdio.addr) {
-                       fp->no_carrier = !new_carrier;
+                       fp->status.link = new_carrier;
                        return 0;
                }
        }
@@ -67,8 +66,6 @@ static int fixed_mdio_read(struct mii_bus *bus, int phy_addr, int reg_num)
 
        list_for_each_entry(fp, &fmb->phys, node) {
                if (fp->addr == phy_addr) {
-                       fp->status.link = !fp->no_carrier;
-
                        /* Issue callback if user registered it. */
                        if (fp->link_update)
                                fp->link_update(fp->phydev->attached_dev,