]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
stop asking users to report unexpected GP login argument arg[19]="4"
authorDaniel Lenski <dlenski@gmail.com>
Fri, 1 May 2020 18:49:25 +0000 (11:49 -0700)
committerDaniel Lenski <dlenski@gmail.com>
Fri, 1 May 2020 18:49:29 +0000 (11:49 -0700)
We still don't know what this one means (my wild guess is that it's telling the client to prefer IPv4), but newer GP servers always send it and it's basically uninteresting.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
auth-globalprotect.c

index 88f3bdbe391485315b7270bf8c8f59da6b3577e7..541e705e8cd2148a8fb85a6fd60fa12446671de7 100644 (file)
@@ -299,7 +299,7 @@ static const struct gp_login_arg gp_login_args[] = {
        { .opt="portal-userauthcookie", .show=1},
        { .opt="portal-prelogonuserauthcookie", .show=1},
        { .unknown=1 },
-       { .unknown=1 },                                 /* have seen value of "4" in some logs */
+       { .opt="usually-equals-4", .show=1 },           /* newer servers send "4" here, meaning unknown */
 };
 static const int gp_login_nargs = (sizeof(gp_login_args)/sizeof(*gp_login_args));