plugins/wdc: don't write invalid log data

In wdc_do_cap_telemetry_log, we currently continue to write log data if
any of the telemetry queries return with < 0.

This change aborts the output write on these errors instead.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

diff --git a/plugins/wdc/wdc-nvme.c b/plugins/wdc/wdc-nvme.c
index 653d89f44355c5146b2087d3064bc3764e4b059d..14ea4ba76acc7680c0e71082a2aeafb03287cc6b 100644 (file)
--- a/plugins/wdc/wdc-nvme.c
+++ b/plugins/wdc/wdc-nvme.c
@@ -2454,9 +2454,10 @@ static int wdc_do_cap_telemetry_log(int fd, char *file, __u32 bs, int type, int
        else
                err = nvme_get_host_telemetry(fd, &log, data_area, &full_size);
 
-       if (err < 0)
+       if (err < 0) {
                perror("get-telemetry-log");
-       else if (err > 0) {
+               goto close_output;
+       } else if (err > 0) {
                nvme_show_status(err);
                fprintf(stderr, "%s: Failed to acquire telemetry header!\n", __func__);
                goto close_output;