]> www.infradead.org Git - users/hch/block.git/commitdiff
ubifs: add check for crypto_shash_tfm_digest
authorChen Ni <nichen@iscas.ac.cn>
Thu, 20 Jun 2024 08:19:26 +0000 (16:19 +0800)
committerRichard Weinberger <richard@nod.at>
Fri, 12 Jul 2024 20:01:09 +0000 (22:01 +0200)
Add check for the return value of crypto_shash_tfm_digest() and return
the error if it fails in order to catch the error.

Fixes: 817aa094842d ("ubifs: support offline signed images")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/master.c

index 7adc37c10b6af48af4f4b82faa9763b3b8e342f8..a148760fa49ed46e910b1af654f0094801e45037 100644 (file)
@@ -67,10 +67,13 @@ static int mst_node_check_hash(const struct ubifs_info *c,
 {
        u8 calc[UBIFS_MAX_HASH_LEN];
        const void *node = mst;
+       int ret;
 
-       crypto_shash_tfm_digest(c->hash_tfm, node + sizeof(struct ubifs_ch),
+       ret = crypto_shash_tfm_digest(c->hash_tfm, node + sizeof(struct ubifs_ch),
                                UBIFS_MST_NODE_SZ - sizeof(struct ubifs_ch),
                                calc);
+       if (ret)
+               return ret;
 
        if (ubifs_check_hash(c, expected, calc))
                return -EPERM;