]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
misc: eeprom/max6875: Constify 'struct bin_attribute'
authorThomas Weißschuh <linux@weissschuh.net>
Sat, 21 Dec 2024 14:48:14 +0000 (15:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Dec 2024 08:36:02 +0000 (09:36 +0100)
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-8-ba5e79fe8771@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/max6875.c

index 6fab2ffa736b741593931c413f230d7c43b5b8dd..1c36ad153e783ead6ba2481c64838390f0bb05f4 100644 (file)
@@ -104,7 +104,7 @@ exit_up:
 }
 
 static ssize_t max6875_read(struct file *filp, struct kobject *kobj,
-                           struct bin_attribute *bin_attr,
+                           const struct bin_attribute *bin_attr,
                            char *buf, loff_t off, size_t count)
 {
        struct i2c_client *client = kobj_to_i2c_client(kobj);
@@ -127,7 +127,7 @@ static const struct bin_attribute user_eeprom_attr = {
                .mode = S_IRUGO,
        },
        .size = USER_EEPROM_SIZE,
-       .read = max6875_read,
+       .read_new = max6875_read,
 };
 
 static int max6875_probe(struct i2c_client *client)