]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
gpio: grgpio: Add NULL check in grgpio_probe
authorCharles Han <hanchunchao@inspur.com>
Thu, 14 Nov 2024 09:18:22 +0000 (17:18 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 18 Nov 2024 10:45:06 +0000 (11:45 +0100)
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in grgpio_probe is not checked.
Add NULL check in grgpio_probe, to handle kernel NULL
pointer dereference error.

Cc: stable@vger.kernel.org
Fixes: 7eb6ce2f2723 ("gpio: Convert to using %pOF instead of full_name")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Link: https://lore.kernel.org/r/20241114091822.78199-1-hanchunchao@inspur.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-grgpio.c

index 7ffe59d845f04258392925c9e34f82ddbb462f33..169f33c41c5925ca97282cb00cf6f6e5180baf06 100644 (file)
@@ -369,6 +369,9 @@ static int grgpio_probe(struct platform_device *ofdev)
        gc->owner = THIS_MODULE;
        gc->to_irq = grgpio_to_irq;
        gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
+       if (!gc->label)
+               return -ENOMEM;
+
        gc->base = -1;
 
        err = of_property_read_u32(np, "nbits", &prop);