]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
dio-writeback-race: fix missing mode in O_CREAT
authorDarrick J. Wong <djwong@kernel.org>
Thu, 20 Feb 2025 21:46:57 +0000 (13:46 -0800)
committerZorro Lang <zlang@kernel.org>
Thu, 6 Mar 2025 13:25:54 +0000 (21:25 +0800)
Fix this build error:

In file included from /usr/include/fcntl.h:314,
                 from dio-writeback-race.c:40:
In function 'open',
    inlined from 'main' at dio-writeback-race.c:110:7:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
   50 |           __open_missing_mode ();
      |           ^~~~~~~~~~~~~~~~~~~~~~

Cc: <fstests@vger.kernel.org> # v2025.02.16
Fixes: 17fb49493426ad ("fstests: add a generic test to verify direct IO writes with buffer contents change")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
src/dio-writeback-race.c

index 963ed207fc1b6b38ac4eca466ba967ad6e8beb9a..2d3156e5b0974a563762656ddb55f548dca0b5d8 100644 (file)
@@ -107,7 +107,7 @@ int main (int argc, char *argv[])
                fprintf(stderr, "failed to allocate aligned memory\n");
                exit(EXIT_FAILURE);
        }
-       fd = open(argv[optind], O_DIRECT | O_WRONLY | O_CREAT);
+       fd = open(argv[optind], O_DIRECT | O_WRONLY | O_CREAT, 0600);
        if (fd < 0) {
                fprintf(stderr, "failed to open file '%s': %m\n", argv[optind]);
                goto error;