]> www.infradead.org Git - users/hch/misc.git/commitdiff
ftrace: Properly merge notrace hashes
authorAndy Chiu <andybnac@gmail.com>
Tue, 8 Apr 2025 16:02:57 +0000 (00:02 +0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 11 Apr 2025 19:14:54 +0000 (15:14 -0400)
The global notrace hash should be jointly decided by the intersection of
each subops's notrace hash, but not the filter hash.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/20250408160258.48563-1-andybnac@gmail.com
Fixes: 5fccc7552ccb ("ftrace: Add subops logic to allow one ops to manage many")
Signed-off-by: Andy Chiu <andybnac@gmail.com>
[ fixed removing of freeing of filter_hash ]
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 1a48aedb52552a1f23c946b547ef15ef582eebe6..8939eeebb02e28e7835a4b18853b050f34992440 100644 (file)
@@ -3526,16 +3526,16 @@ int ftrace_startup_subops(struct ftrace_ops *ops, struct ftrace_ops *subops, int
            ftrace_hash_empty(subops->func_hash->notrace_hash)) {
                notrace_hash = EMPTY_HASH;
        } else {
-               size_bits = max(ops->func_hash->filter_hash->size_bits,
-                               subops->func_hash->filter_hash->size_bits);
+               size_bits = max(ops->func_hash->notrace_hash->size_bits,
+                               subops->func_hash->notrace_hash->size_bits);
                notrace_hash = alloc_ftrace_hash(size_bits);
                if (!notrace_hash) {
                        free_ftrace_hash(filter_hash);
                        return -ENOMEM;
                }
 
-               ret = intersect_hash(&notrace_hash, ops->func_hash->filter_hash,
-                                    subops->func_hash->filter_hash);
+               ret = intersect_hash(&notrace_hash, ops->func_hash->notrace_hash,
+                                    subops->func_hash->notrace_hash);
                if (ret < 0) {
                        free_ftrace_hash(filter_hash);
                        free_ftrace_hash(notrace_hash);