plugin: Return EINVAL instead of ENOTTY

When a given string for a subcommand is not valid, we can return EINVAL which
means invalid arguments.  ENOTTY is used to indicate that an invalid IOCTL
number was specified.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>

diff --git a/nvme.c b/nvme.c
index 5606bc50e1139cbc537b28fdabf828e4be2d8873..84ff4e8c78342862411cfccfdd34b17ede0c67b1 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -4962,7 +4962,7 @@ int main(int argc, char **argv)
        setlocale(LC_ALL, "");
 
        ret = handle_plugin(argc - 1, &argv[1], nvme.extensions);
-       if (ret == -ENOTTY)
+       if (ret == -EINVAL)
                general_help(&builtin);
 
        return ret;

diff --git a/plugin.c b/plugin.c
index 4750df6bd50b68f2d16d8d645f1572d34057d5ee..aa49501ec76308056de02cf37adcc85998fa1c96 100644 (file)
--- a/plugin.c
+++ b/plugin.c
@@ -161,7 +161,7 @@ int handle_plugin(int argc, char **argv, struct plugin *plugin)
        /* Check extensions only if this is running the built-in plugin */
        if (plugin->name) { 
                printf("ERROR: Invalid sub-command '%s' for plugin %s\n", str, plugin->name);
-               return -ENOTTY;
+               return -EINVAL;
         }
 
        extension = plugin->next;
@@ -184,5 +184,5 @@ int handle_plugin(int argc, char **argv, struct plugin *plugin)
                extension = extension->next;
        }
        printf("ERROR: Invalid sub-command '%s'\n", str);
-       return -ENOTTY;
+       return -EINVAL;
 }