ASoC: sun4i-i2s: Update global enable with bitmask

The default value of the config register is different on newer
SoCs and therefore enabling/disabling with a register write
will clear bits used to set the direction of the clock and frame
pins.

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 573acca24a2c6f9f95256d3ab4300539abc737c3..19d50ca10d1f21f63f6fc49f11a8b5a807a00201 100644 (file)
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -529,8 +529,8 @@ static int sun4i_i2s_startup(struct snd_pcm_substream *substream,
        struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
        /* Enable the whole hardware block */
-       regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
-                    SUN4I_I2S_CTRL_GL_EN);
+       regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+                          SUN4I_I2S_CTRL_GL_EN, SUN4I_I2S_CTRL_GL_EN);
 
        /* Enable the first output line */
        regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
@@ -553,7 +553,8 @@ static void sun4i_i2s_shutdown(struct snd_pcm_substream *substream,
                           SUN4I_I2S_CTRL_SDO_EN_MASK, 0);
 
        /* Disable the whole hardware block */
-       regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG, 0);
+       regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+                          SUN4I_I2S_CTRL_GL_EN, 0);
 }
 
 static int sun4i_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,