]> www.infradead.org Git - users/willy/xarray.git/commitdiff
iio: light: ltr390: simplify code in write_event_config callback
authorJulien Stephan <jstephan@baylibre.com>
Thu, 31 Oct 2024 15:26:56 +0000 (16:26 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 3 Nov 2024 20:33:43 +0000 (20:33 +0000)
iio_ev_state_store is actually using kstrtobool to check user
input, then gives the converted boolean value to the write_event_config
callback.

Remove useless code in write_event_config callback.

Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Link: https://patch.msgid.link/20241031-iio-fix-write-event-config-signature-v2-1-2bcacbb517a2@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/ltr390.c

index 8e0a3fc3d923a6f65d2a629c87e7bfd35d82a507..3bdffb6360bcbaab4df1a2d39c8ea3813b5d6bd3 100644 (file)
@@ -558,10 +558,7 @@ static int ltr390_write_event_config(struct iio_dev *indio_dev,
        struct ltr390_data *data = iio_priv(indio_dev);
        int ret;
 
-       if (state != 1  && state != 0)
-               return -EINVAL;
-
-       if (state == 0)
+       if (!state)
                return regmap_clear_bits(data->regmap, LTR390_INT_CFG, LTR390_LS_INT_EN);
 
        guard(mutex)(&data->lock);