]> www.infradead.org Git - users/hch/misc.git/commitdiff
i3c: master: svc: Fix missing STOP for master request
authorStanley Chu <yschu@nuvoton.com>
Tue, 18 Mar 2025 05:36:06 +0000 (13:36 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 18 Mar 2025 16:14:35 +0000 (17:14 +0100)
The controller driver nacked the master request but didn't emit a
STOP to end the transaction. The driver shall refuse the unsupported
requests and return the controller state to IDLE by emitting a STOP.

Signed-off-by: Stanley Chu <yschu@nuvoton.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250318053606.3087121-4-yschu@nuvoton.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/svc-i3c-master.c

index 57b9dec6b5a8909d8d11bcc572bc684e5624a190..e0cd3ce28b7f781a3925d8eadb666b29f8b55adf 100644 (file)
@@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
                        queue_work(master->base.wq, &master->hj_work);
                break;
        case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST:
+               svc_i3c_master_emit_stop(master);
        default:
                break;
        }