drm/nouveau: use drm_property_create_range helper

Avoids potential null pointer dereference.

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 508b00a2ce0de6d48b80e33d1ef1bc515598b3d2..e2fdd7552e1bbdacf2dc41c5270ce1786441b2f1 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -316,17 +316,13 @@ nouveau_display_create(struct drm_device *dev)
                drm_property_create_range(dev, 0, "underscan vborder", 0, 128);
 
        if (gen >= 1) {
+               /* -90..+90 */
                disp->vibrant_hue_property =
-                       drm_property_create(dev, DRM_MODE_PROP_RANGE,
-                                           "vibrant hue", 2);
-               disp->vibrant_hue_property->values[0] = 0;
-               disp->vibrant_hue_property->values[1] = 180; /* -90..+90 */
+                       drm_property_create_range(dev, 0, "vibrant hue", 0, 180);
 
+               /* -100..+100 */
                disp->color_vibrance_property =
-                       drm_property_create(dev, DRM_MODE_PROP_RANGE,
-                                           "color vibrance", 2);
-               disp->color_vibrance_property->values[0] = 0;
-               disp->color_vibrance_property->values[1] = 200; /* -100..+100 */
+                       drm_property_create_range(dev, 0, "color vibrance", 0, 200);
        }
 
        dev->mode_config.funcs = &nouveau_mode_config_funcs;