cxgb4: Initialize mbox lock and list for mgmt dev

Initialize mbox lock and list for mgmt dev to avoid NULL pointer
dereference when cxgb_set_vf_mac is called.

And also allocate memory for private data while allocating mgmt
netdev.

Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 3349e1f376c3e1f7fd081cc02ac6d6c3e64e1282..e95bb6a0eca8f7ca177da7b67f1cd51721dca09b 100644 (file)
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -4516,7 +4516,8 @@ static int config_mgmt_dev(struct pci_dev *pdev)
        int err;
 
        snprintf(name, IFNAMSIZ, "mgmtpf%d%d", adap->adap_idx, adap->pf);
-       netdev = alloc_netdev(0, name, NET_NAME_UNKNOWN, dummy_setup);
+       netdev = alloc_netdev(sizeof(struct port_info), name, NET_NAME_UNKNOWN,
+                             dummy_setup);
        if (!netdev)
                return -ENOMEM;
 
@@ -4990,6 +4991,8 @@ sriov:
                err = -ENOMEM;
                goto free_adapter;
        }
+       spin_lock_init(&adapter->mbox_lock);
+       INIT_LIST_HEAD(&adapter->mlist.list);
        pci_set_drvdata(pdev, adapter);
        return 0;