]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bnx2x: unlock before returning an error
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 24 Jan 2012 21:59:31 +0000 (21:59 +0000)
committerJoe Jin <joe.jin@oracle.com>
Wed, 16 May 2012 14:41:18 +0000 (22:41 +0800)
We introduced a new return here but forgot to drop the lock.

(cherry picked from commit a44acd551467d78a26bfa76ea348225575830efc)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/bnx2x/bnx2x_sp.c

index 13c5f26a35fe8870df095ea9fbcbdf0abca63da4..af28c30b411cce39100c0773bf75ebc7fed5502a 100644 (file)
@@ -1837,6 +1837,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
                        rc = exeq->remove(bp, exeq->owner, exeq_pos);
                        if (rc) {
                                BNX2X_ERR("Failed to remove command\n");
+                               spin_unlock_bh(&exeq->lock);
                                return rc;
                        }
                        list_del(&exeq_pos->link);