drm: msm: fix error check return value of irq_of_parse_and_map()

[ Upstream commit b9e4f1d2b505df8e2439b63e67afaa287c1c43e2 ]

The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/483175/
Link: https://lore.kernel.org/r/20220424031959.3172406-1-lv.ruyi@zte.com.cn
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
index e193865ce9a26e557ee158651d5b9ae342b980bf..9baaaef706ab5c208a6d75d697c997c53005d9b5 100644 (file)
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
@@ -598,9 +598,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev)
        pdev = mdp5_kms->pdev;
 
        irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
-       if (irq < 0) {
-               ret = irq;
-               DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret);
+       if (!irq) {
+               ret = -EINVAL;
+               DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n");
                goto fail;
        }