]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
fabrics: fix segfault when -t <transport> is not passed
authorSagi Grimberg <sagi@grimberg.me>
Wed, 19 Aug 2020 10:31:57 +0000 (03:31 -0700)
committerKeith Busch <kbusch@kernel.org>
Wed, 19 Aug 2020 21:54:09 +0000 (14:54 -0700)
Need to check if transport was provided before we derefernce
it.

Fixes: 9da606b4afcc ("fabrics: allow traddr to be host name for ip based transports")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
fabrics.c

index 73bb3752944892db58d173a4bded79309a1c8b56..c93b752ff1424e4c41ff71e5d03d50f0b6cd8be4 100644 (file)
--- a/fabrics.c
+++ b/fabrics.c
@@ -923,7 +923,7 @@ static bool traddr_is_hostname(struct config *cfg)
 {
        char addrstr[NVMF_TRADDR_SIZE];
 
-       if (!cfg->traddr)
+       if (!cfg->traddr || !cfg->transport)
                return false;
        if (strcmp(cfg->transport, "tcp") && strcmp(cfg->transport, "rdma"))
                return false;