md: remove redundant check in fix_read_error()

In fix_read_error(), 'success' will be checked immediately after assigning
it, if it is set to 1 then the loop will break. Checking it again in
condition of loop is redundant. Clean it up.

Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230623173236.2513554-3-linan666@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org>

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index f834d99a36f6dda5e454b0991a00cf91db0744df..a68c9cccbf0d2a18c8903a8ad2421bdff84504d5 100644 (file)
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -2301,7 +2301,7 @@ static void fix_read_error(struct r1conf *conf, int read_disk,
                        d++;
                        if (d == conf->raid_disks * 2)
                                d = 0;
-               } while (!success && d != read_disk);
+               } while (d != read_disk);
 
                if (!success) {
                        /* Cannot read from anywhere - mark it bad */

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index abea91a54db1dccb5c9fbb668a15077fcb4adec6..757687fb90a7a24815c09e3322c5d8b7bc3f7ff5 100644 (file)
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2783,7 +2783,7 @@ static void fix_read_error(struct r10conf *conf, struct mddev *mddev, struct r10
                        sl++;
                        if (sl == conf->copies)
                                sl = 0;
-               } while (!success && sl != slot);
+               } while (sl != slot);
                rcu_read_unlock();
 
                if (!success) {