]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
usb: storage: realtek_cr: Use const for constant arrays
authorJonathan Neuschäfer <j.ne@posteo.net>
Fri, 28 Feb 2025 15:11:21 +0000 (16:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Mar 2025 09:24:41 +0000 (10:24 +0100)
These arrays are only read, never modified.

Declaring data as const makes it easier to see what's going on, and can
prevent unintended writes through placement in a read-only section.

Signed-off-by: Jonathan Neuschäfer <j.ne@posteo.net>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20250228-misc-const-v3-6-09b417ded9c4@posteo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/realtek_cr.c

index 2a82ed7b68eaa75993e786afeda0d5d3a3c3bfce..4e516b44513672ebe7889247a70043e0dd013bc8 100644 (file)
@@ -191,7 +191,7 @@ MODULE_DEVICE_TABLE(usb, realtek_cr_ids);
        .initFunction = init_function,  \
 }
 
-static struct us_unusual_dev realtek_cr_unusual_dev_list[] = {
+static const struct us_unusual_dev realtek_cr_unusual_dev_list[] = {
 #      include "unusual_realtek.h"
        {}                      /* Terminating entry */
 };
@@ -797,10 +797,10 @@ static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
 {
        struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra);
        static int card_first_show = 1;
-       static u8 media_not_present[] = { 0x70, 0, 0x02, 0, 0, 0, 0,
+       static const u8 media_not_present[] = { 0x70, 0, 0x02, 0, 0, 0, 0,
                10, 0, 0, 0, 0, 0x3A, 0, 0, 0, 0, 0
        };
-       static u8 invalid_cmd_field[] = { 0x70, 0, 0x05, 0, 0, 0, 0,
+       static const u8 invalid_cmd_field[] = { 0x70, 0, 0x05, 0, 0, 0, 0,
                10, 0, 0, 0, 0, 0x24, 0, 0, 0, 0, 0
        };
        int ret;