net: mvneta: remove duplicate *_coal assignment

The style of the rx/tx queue's *_coal member assignment is:

static void foo_coal_set(...)
{
	set the coal in hw;
	update queue's foo_coal member; [1]
}

In other place, we call foo_coal_set(pp, queue->foo_coal), so the above [1]
is duplicated and could be removed.

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 25ced96750bf1f5aa7e9ac94b0bf71f071094d26..a58acdb5eba3fe8890ec0649a90657cb5327f50f 100644 (file)
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -1555,7 +1555,6 @@ static void mvneta_rx_pkts_coal_set(struct mvneta_port *pp,
 {
        mvreg_write(pp, MVNETA_RXQ_THRESHOLD_REG(rxq->id),
                    value | MVNETA_RXQ_NON_OCCUPIED(0));
-       rxq->pkts_coal = value;
 }
 
 /* Set the time delay in usec before RX interrupt will be generated by
@@ -1571,7 +1570,6 @@ static void mvneta_rx_time_coal_set(struct mvneta_port *pp,
        val = (clk_rate / 1000000) * value;
 
        mvreg_write(pp, MVNETA_RXQ_TIME_COAL_REG(rxq->id), val);
-       rxq->time_coal = value;
 }
 
 /* Set threshold for TX_DONE pkts coalescing */
@@ -1586,8 +1584,6 @@ static void mvneta_tx_done_pkts_coal_set(struct mvneta_port *pp,
        val |= MVNETA_TXQ_SENT_THRESH_MASK(value);
 
        mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), val);
-
-       txq->done_pkts_coal = value;
 }
 
 /* Handle rx descriptor fill by setting buf_cookie and buf_phys_addr */