]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: fec_mpc52xx_phy: Use %pa to format resource_size_t
authorSimon Horman <horms@kernel.org>
Mon, 14 Oct 2024 10:48:07 +0000 (11:48 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Oct 2024 17:55:54 +0000 (10:55 -0700)
The correct format string for resource_size_t is %pa which
acts on the address of the variable to be formatted [1].

[1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229

Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string")

Flagged by gcc-14 as:

drivers/net/ethernet/freescale/fec_mpc52xx_phy.c: In function 'mpc52xx_fec_mdio_probe':
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c:97:46: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
   97 |         snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start);
      |                                             ~^   ~~~~~~~~~
      |                                              |      |
      |                                              |      resource_size_t {aka long long unsigned int}
      |                                              unsigned int
      |                                             %llx

No functional change intended.
Compile tested only.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Link: https://patch.msgid.link/20241014-net-pa-fmt-v1-1-dcc9afb8858b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c

index 2c37004bb0fe9622afd9c8e95249dce82d6c98b0..3d073f0fae6302af374f01fb0d301a1f7ae079f0 100644 (file)
@@ -94,7 +94,7 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of)
                goto out_free;
        }
 
-       snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start);
+       snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res.start);
        bus->priv = priv;
 
        bus->parent = dev;