]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
x86/fpu: Check TIF_NEED_FPU_LOAD instead of PF_KTHREAD|PF_USER_WORKER in fpu__drop()
authorOleg Nesterov <oleg@redhat.com>
Sat, 3 May 2025 14:38:56 +0000 (16:38 +0200)
committerIngo Molnar <mingo@kernel.org>
Sun, 4 May 2025 08:29:25 +0000 (10:29 +0200)
PF_KTHREAD|PF_USER_WORKER tasks should never clear TIF_NEED_FPU_LOAD,
so the TIF_NEED_FPU_LOAD check should equally filter them out.

And this way an exiting userspace task can avoid the unnecessary "fwait"
if it does context_switch() at least once on its way to exit_thread().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Chang S . Bae <chang.seok.bae@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250503143856.GA9009@redhat.com
arch/x86/kernel/fpu/core.c

index 8d674435f1731c5eae4b50eeeacb7d6efb2b1f7d..fa131299c7da30abb10f4cfbed9d6ceb1780030e 100644 (file)
@@ -693,8 +693,7 @@ void fpu__drop(struct task_struct *tsk)
 {
        struct fpu *fpu;
 
-       /* PF_KTHREAD tasks do not use the FPU context area: */
-       if (tsk->flags & (PF_KTHREAD | PF_USER_WORKER))
+       if (test_tsk_thread_flag(tsk, TIF_NEED_FPU_LOAD))
                return;
 
        fpu = x86_task_fpu(tsk);