]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
btrfs/028: removed redundant sync and scratch filesystem unmount
authorFilipe Manana <fdmanana@suse.com>
Wed, 27 Mar 2024 17:11:37 +0000 (17:11 +0000)
committerAnand Jain <anand.jain@oracle.com>
Wed, 3 Apr 2024 07:08:08 +0000 (15:08 +0800)
There's no need to have an explicit scratch filesystem sync and unmount
at the of the test, as the fstests framework automatically unmounts the
filesystem and the unmount naturally syncs any data and metadata.

So remove them and update the comment to be more clear.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
tests/btrfs/028

index 8fbe8887f84bd95c6c5ff5e1b362dae601f4ed02..0c96b2fec7ca151819483d738a20e26180ab0a16 100755 (executable)
@@ -48,11 +48,8 @@ kill $fsstress_pid &> /dev/null
 wait $fsstress_pid &> /dev/null
 _btrfs_kill_stress_balance_pid $balance_pid
 
-_run_btrfs_util_prog filesystem sync $SCRATCH_MNT
-
-_scratch_unmount
-
-# qgroup will be checked at _check_scratch_fs() by fstest.
+# The qgroups accounting will be checked by 'btrfs check' (fsck) after the
+# fstests framework unmounts the filesystem.
 echo "Silence is golden"
 status=0