]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
scsi: qla4xxx: Fix missing DMA mapping error in qla4xxx_alloc_pdu()
authorThomas Fourier <fourier.thomas@gmail.com>
Wed, 18 Jun 2025 07:17:37 +0000 (09:17 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 23 Jun 2025 17:23:45 +0000 (13:23 -0400)
dma_map_XXX() can fail and should be tested for errors with
dma_mapping_error().

Fixes: b3a271a94d00 ("[SCSI] qla4xxx: support iscsiadm session mgmt")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Link: https://lore.kernel.org/r/20250618071742.21822-2-fourier.thomas@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla4xxx/ql4_os.c

index d4141656b20467d610d26901ed00a655a2a70c1c..a39f1da4ce474b8068cb63564da8db5a4c6421c9 100644 (file)
@@ -3420,6 +3420,8 @@ static int qla4xxx_alloc_pdu(struct iscsi_task *task, uint8_t opcode)
                task_data->data_dma = dma_map_single(&ha->pdev->dev, task->data,
                                                     task->data_count,
                                                     DMA_TO_DEVICE);
+               if (dma_mapping_error(&ha->pdev->dev, task_data->data_dma))
+                       return -ENOMEM;
        }
 
        DEBUG2(ql4_printk(KERN_INFO, ha, "%s: MaxRecvLen %u, iscsi hrd %d\n",