]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: stmmac: sunxi: remove of_get_phy_mode()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 12 Mar 2025 09:21:07 +0000 (09:21 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 14:53:16 +0000 (15:53 +0100)
devm_stmmac_probe_config_dt() already gets the PHY mode from firmware,
which is stored in plat_dat->phy_interface. Therefore, we don't need to
get it in platform code.

Set gmac->interface from plat_dat->phy_interface.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tsIGx-005v0F-Ev@rmk-PC.armlinux.org.uk
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c

index 1b1ce2888b2eb6d562c990a843a9ddb61a1539fb..9f098ff0ff05851017596c8bcb522d7a1f445a3c 100644 (file)
@@ -116,11 +116,7 @@ static int sun7i_gmac_probe(struct platform_device *pdev)
        if (!gmac)
                return -ENOMEM;
 
-       ret = of_get_phy_mode(dev->of_node, &gmac->interface);
-       if (ret && ret != -ENODEV) {
-               dev_err(dev, "Can't get phy-mode\n");
-               return ret;
-       }
+       gmac->interface = plat_dat->phy_interface;
 
        gmac->tx_clk = devm_clk_get(dev, "allwinner_gmac_tx");
        if (IS_ERR(gmac->tx_clk)) {