net: ethernet: mtk_eth_soc: fix error code in mtk_flow_offload_replace()

Preserve the error code from mtk_foe_entry_commit().  Do not return
success.

Fixes: c4f033d9e03e ("net: ethernet: mtk_eth_soc: rework hardware flow table management")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
index c9353071f96aa97de09e77b7a51c5ae66b40a797..90e7dfd011c91f0cdb20b01d9d4cba7fc9730453 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
@@ -435,7 +435,8 @@ mtk_flow_offload_replace(struct mtk_eth *eth, struct flow_cls_offload *f)
        memcpy(&entry->data, &foe, sizeof(entry->data));
        entry->wed_index = wed_index;
 
-       if (mtk_foe_entry_commit(eth->ppe, entry) < 0)
+       err = mtk_foe_entry_commit(eth->ppe, entry);
+       if (err < 0)
                goto free;
 
        err = rhashtable_insert_fast(&eth->flow_table, &entry->node,