]> www.infradead.org Git - users/hch/xfsprogs.git/commit
xfs: fix inverted return from xfs_btree_sblock_verify_crc libxfs-4.20-sync
authorEric Sandeen <sandeen@redhat.com>
Wed, 12 Dec 2018 17:36:08 +0000 (11:36 -0600)
committerEric Sandeen <sandeen@redhat.com>
Wed, 12 Dec 2018 17:36:08 +0000 (11:36 -0600)
commitdbd3d464a79a47bd75544cc493cc63e9522dd58d
tree84a218a0965a9614f792313bab6c80a67a4984f0
parent3833299fdac664b9601b71267237c25dad8f26bc
xfs: fix inverted return from xfs_btree_sblock_verify_crc

Source kernel commit: 7d048df4e9b05ba89b74d062df59498aa81f3785

xfs_btree_sblock_verify_crc is a bool so should not be returning
a failaddr_t; worse, if xfs_log_check_lsn fails it returns
__this_address which looks like a boolean true (i.e. success)
to the caller.

(interestingly xfs_btree_lblock_verify_crc doesn't have the issue)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_btree.c