]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fs/ntfs3: Fix WARNING in ntfs_extend_initialized_size
authorEdward Adam Davis <eadavis@qq.com>
Mon, 14 Oct 2024 12:16:38 +0000 (20:16 +0800)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Wed, 5 Feb 2025 14:48:40 +0000 (17:48 +0300)
commitff355926445897cc9fdea3b00611e514232c213c
tree0e0bafe48257a80de3f2cb9a73f1adb14a7db824
parent1d1a7e2525491f56901f5f63370a0775768044b8
fs/ntfs3: Fix WARNING in ntfs_extend_initialized_size

Syzbot reported a WARNING in ntfs_extend_initialized_size.
The data type of in->i_valid and to is u64 in ntfs_file_mmap().
If their values are greater than LLONG_MAX, overflow will occur because
the data types of the parameters valid and new_valid corresponding to
the function ntfs_extend_initialized_size() are loff_t.

Before calling ntfs_extend_initialized_size() in the ntfs_file_mmap(),
the "ni->i_valid < to" has been determined, so the same WARN_ON determination
is not required in ntfs_extend_initialized_size().
Just execute the ntfs_extend_initialized_size() in ntfs_extend() to make
a WARN_ON check.

Reported-and-tested-by: syzbot+e37dd1dfc814b10caa55@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=e37dd1dfc814b10caa55
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/file.c