]> www.infradead.org Git - users/hch/misc.git/commit
platform/x86: asus-wmi: Refactor Ally suspend/resume
authorLuke D. Jones <luke@ljones.dev>
Sun, 23 Mar 2025 02:34:21 +0000 (15:34 +1300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 8 May 2025 13:03:56 +0000 (16:03 +0300)
commitfeea7bd6b02d43a794e3f065650d89cf8d8e8e59
tree137adf7e13add1f8c2c8e6607881a4da07e32834
parent00e005c952f74f50a3f86af96f56877be4685e14
platform/x86: asus-wmi: Refactor Ally suspend/resume

Adjust how the CSEE direct call hack is used.

The results of months of testing combined with help from ASUS to
determine the actual cause of suspend issues has resulted in this
refactoring which immensely improves the reliability for devices which
do not have the following minimum MCU FW version:
- ROG Ally X: 313
- ROG Ally 1: 319

For MCU FW versions that match the minimum or above the CSEE hack is
disabled and mcu_powersave set to on by default as there are no
negatives beyond a slightly slower device reinitialization due to the
MCU being powered off.

As this is set only at module load time, it is still possible for
mcu_powersave sysfs attributes to change it at runtime if so desired.

Signed-off-by: Luke D. Jones <luke@ljones.dev>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20250323023421.78012-3-luke@ljones.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/hid/hid-asus.c
drivers/platform/x86/asus-wmi.c
include/linux/platform_data/x86/asus-wmi.h