]> www.infradead.org Git - nvme.git/commit
tools/power turbostat: Fix trailing '\n' parsing
authorZhang Rui <rui.zhang@intel.com>
Tue, 27 Aug 2024 05:07:51 +0000 (13:07 +0800)
committerLen Brown <len.brown@intel.com>
Sat, 30 Nov 2024 21:42:06 +0000 (16:42 -0500)
commitfed8511cc8996989178823052dc0200643e1389a
tree6d1541e249f6fcc12b96e9f3dfeb32042793e96f
parentae2cdf8d92ffc326104524a1f9da4cf75b6ea996
tools/power turbostat: Fix trailing '\n' parsing

parse_cpu_string() parses the string input either from command line or
from /sys/fs/cgroup/cpuset.cpus.effective to get a list of CPUs that
turbostat can run with.

The cpu string returned by /sys/fs/cgroup/cpuset.cpus.effective contains
a trailing '\n', but strtoul() fails to treat this as an error.

That says, for the code below
val = ("\n", NULL, 10);
val returns 0, and errno is also not set.

As a result, CPU0 is erroneously considered as allowed CPU and this
causes failures when turbostat tries to run on CPU0.

 get_counters: Could not migrate to CPU 0
 ...
 turbostat: re-initialized with num_cpus 8, allowed_cpus 5
 get_counters: Could not migrate to CPU 0

Add a check to return immediately if '\n' or '\0' is detected.

Fixes: 8c3dd2c9e542 ("tools/power/turbostat: Abstrct function for parsing cpu string")
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
tools/power/x86/turbostat/turbostat.c