]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/amdgpu: disallow multiple BO_HANDLES chunks in one submit
authorPierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Tue, 2 Jul 2024 09:54:30 +0000 (11:54 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 23 Jul 2024 21:33:57 +0000 (17:33 -0400)
commitfec5f8e8c6bcf83ed7a392801d7b44c5ecfc1e82
tree19a00b28fd14614c4269a4c00e52ba5a4f3bbcc5
parent80237bfc031cd74cb8abf0d21094207284d56a48
drm/amdgpu: disallow multiple BO_HANDLES chunks in one submit

Before this commit, only submits with both a BO_HANDLES chunk and a
'bo_list_handle' would be rejected (by amdgpu_cs_parser_bos).

But if UMD sent multiple BO_HANDLES, what would happen is:
* only the last one would be really used
* all the others would leak memory as amdgpu_cs_p1_bo_handles would
  overwrite the previous p->bo_list value

This commit rejects submissions with multiple BO_HANDLES chunks to
match the implementation of the parser.

Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c