]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT_PIN
authorWei Liu <wei.liu@kernel.org>
Mon, 1 Jul 2024 20:26:05 +0000 (20:26 +0000)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 3 Jul 2024 21:11:14 +0000 (21:11 +0000)
commitfea93a3e5d5e6a09eb153866d2ce60ea3287a70d
treef40a4ae5808738194eb31902d2f8360a483bc0a6
parent1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT_PIN

The intent of the code snippet is to always return 0 for both
PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN.

The check misses PCI_INTERRUPT_PIN. This patch fixes that.

This is discovered by this call in VFIO:

    pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin);

The old code does not set *val to 0 because it misses the check for
PCI_INTERRUPT_PIN. Garbage is returned in that case.

Fixes: 4daace0d8ce8 ("PCI: hv: Add paravirtual PCI front-end for Microsoft Hyper-V VMs")
Link: https://lore.kernel.org/linux-pci/20240701202606.129606-1-wei.liu@kernel.org
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Cc: stable@kernel.org
drivers/pci/controller/pci-hyperv.c