]> www.infradead.org Git - users/jedix/linux-maple.git/commit
static_call: Replace pointless WARN_ON() in static_call_module_notify()
authorThomas Gleixner <tglx@linutronix.de>
Wed, 4 Sep 2024 09:08:28 +0000 (11:08 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 6 Sep 2024 14:29:22 +0000 (16:29 +0200)
commitfe513c2ef0a172a58f158e2e70465c4317f0a9a2
treeb3f49c8908db340dc3d29e949b66a6e1856373a2
parent4b30051c4864234ec57290c3d142db7c88f10d8a
static_call: Replace pointless WARN_ON() in static_call_module_notify()

static_call_module_notify() triggers a WARN_ON(), when memory allocation
fails in __static_call_add_module().

That's not really justified, because the failure case must be correctly
handled by the well known call chain and the error code is passed
through to the initiating userspace application.

A memory allocation fail is not a fatal problem, but the WARN_ON() takes
the machine out when panic_on_warn is set.

Replace it with a pr_warn().

Fixes: 9183c3f9ed71 ("static_call: Add inline static call infrastructure")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/8734mf7pmb.ffs@tglx
kernel/static_call_inline.c