]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xhci: Mitigate failed set dequeue pointer commands
authorMathias Nyman <mathias.nyman@linux.intel.com>
Wed, 16 Oct 2024 13:59:58 +0000 (16:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 06:45:36 +0000 (08:45 +0200)
commitfe49df60cdb7c2975aa743dc295f8786e4b7db10
tree4f6f84c1d23668cbcd8633944125f259b31480f6
parent6599b6a6fa8060145046d0744456b6abdb3122a7
xhci: Mitigate failed set dequeue pointer commands

Avoid xHC host from processing a cancelled URB by always turning
cancelled URB TDs into no-op TRBs before queuing a 'Set TR Deq' command.

If the command fails then xHC will start processing the cancelled TD
instead of skipping it once endpoint is restarted, causing issues like
Babble error.

This is not a complete solution as a failed 'Set TR Deq' command does not
guarantee xHC TRB caches are cleared.

Fixes: 4db356924a50 ("xhci: turn cancelled td cleanup to its own function")
Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20241016140000.783905-3-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c