]> www.infradead.org Git - users/willy/xarray.git/commit
drm/xe/pcode: Treat pcode as per-tile rather than per-GT
authorMatt Roper <matthew.d.roper@intel.com>
Thu, 29 Aug 2024 22:06:21 +0000 (15:06 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 3 Sep 2024 14:36:46 +0000 (10:36 -0400)
commitfe13fd68337512da4b7aee6326c397e817a943c7
tree893be926bd3511cf7786d3141bb2bb97418bb903
parent529bf8d1118bbaa1aa835563a22b0b5c64ca9d68
drm/xe/pcode: Treat pcode as per-tile rather than per-GT

There's only one instance of the pcode per tile, and for GT-related
accesses both the primary and media GT share the same register
interface.  Since Xe was using per-GT locking, the pcode mutex wasn't
actually protecting everything that it should since concurrent accesses
related to a tile's primary GT and media GT were possible.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240829220619.789159-5-matthew.d.roper@intel.com
(cherry picked from commit 3034cc8107b8d0c7d1b56584394e215dab57f8a3)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/compat-i915-headers/intel_pcode.h
drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
drivers/gpu/drm/xe/xe_device_types.h
drivers/gpu/drm/xe/xe_gt.c
drivers/gpu/drm/xe/xe_gt_types.h
drivers/gpu/drm/xe/xe_guc_pc.c
drivers/gpu/drm/xe/xe_hwmon.c
drivers/gpu/drm/xe/xe_pcode.c
drivers/gpu/drm/xe/xe_pcode.h
drivers/gpu/drm/xe/xe_tile.c
drivers/gpu/drm/xe/xe_vram_freq.c